lkml.org 
[lkml]   [2018]   [Jul]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 13/18] staging: gasket: gasket_enable_dev fixups
On Fri, Jul 13, 2018 at 10:58:11PM -0700, Todd Poynor wrote:
> From: Todd Poynor <toddpoynor@google.com>
>
> Remove unnecessary variable.
>
> Bail out if no physical device.
>
> Signed-off-by: Todd Poynor <toddpoynor@google.com>
> ---
> drivers/staging/gasket/gasket_core.c | 19 ++++++-------------
> 1 file changed, 6 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/staging/gasket/gasket_core.c b/drivers/staging/gasket/gasket_core.c
> index 65aa7cf454fb..f7d8f66e8746 100644
> --- a/drivers/staging/gasket/gasket_core.c
> +++ b/drivers/staging/gasket/gasket_core.c
> @@ -915,8 +915,6 @@ static int gasket_enable_dev(
> {
> int tbl_idx;
> int ret;
> - bool has_dma_ops;
> - struct device *ddev;
> const struct gasket_driver_desc *driver_desc =
> internal_desc->driver_desc;
>
> @@ -934,26 +932,21 @@ static int gasket_enable_dev(
> return ret;
> }
>
> - has_dma_ops = true;
> + if (!gasket_dev->pci_dev) {
> + gasket_log_error(gasket_dev,
> + "%s: no physical device", __func__);
> + return -ENODEV;
> + }

How can this ever be true? I don't see where this can be removed to
enable this error check to be hit. What am I missing?

thanks,

greg k-h
\
 
 \ /
  Last update: 2018-07-15 22:07    [W:0.184 / U:3.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site