lkml.org 
[lkml]   [2018]   [Jul]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 08/18] staging: gasket: gasket_wait_with_reschedule fixups
On Fri, Jul 13, 2018 at 10:58:06PM -0700, Todd Poynor wrote:
> From: Todd Poynor <toddpoynor@google.com>
>
> Return -ETIMEDOUT on timeouts.
>
> Don't need 64-bit sized retry count.
>
> Use msleep().
>
> Return immediately when condition hit.

Huge hint, when you have to list the different things you do in a patch,
that means it should be split up into smaller patches.

Please rework this patch series based on this. I'll stop reviewing them
now and wait for a new set of patches.

thanks,

greg k-h
\
 
 \ /
  Last update: 2018-07-15 22:07    [W:0.180 / U:0.852 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site