lkml.org 
[lkml]   [2018]   [Jul]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] vme: ca91cx42: remove redundant variable i
On Sat, Jul 14, 2018 at 05:33:32PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Variable i is being assigned but is never used hence it is redundant
> and can be removed.
>
> Cleans up clang warning:
> warning: variable 'i' set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Reviewed-by: Martyn Welch <martyn@welchs.me.uk>

> ---
> drivers/vme/bridges/vme_ca91cx42.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/vme/bridges/vme_ca91cx42.c b/drivers/vme/bridges/vme_ca91cx42.c
> index 5dd284008630..53bdc256805f 100644
> --- a/drivers/vme/bridges/vme_ca91cx42.c
> +++ b/drivers/vme/bridges/vme_ca91cx42.c
> @@ -970,7 +970,6 @@ static unsigned int ca91cx42_master_rmw(struct vme_master_resource *image,
> {
> u32 result;
> uintptr_t pci_addr;
> - int i;
> struct ca91cx42_driver *bridge;
> struct device *dev;
>
> @@ -978,7 +977,6 @@ static unsigned int ca91cx42_master_rmw(struct vme_master_resource *image,
> dev = image->parent->parent;
>
> /* Find the PCI address that maps to the desired VME address */
> - i = image->number;
>
> /* Locking as we can only do one of these at a time */
> mutex_lock(&bridge->vme_rmw);
> --
> 2.17.1
>
\
 
 \ /
  Last update: 2018-07-15 22:07    [W:0.060 / U:6.596 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site