lkml.org 
[lkml]   [2018]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4] PCI/AER: Fix aerdrv loading with "pcie_ports=native" parameter
On Tue, Jul 03, 2018 at 06:27:43PM -0500, Alexandru Gagniuc wrote:
> According to the documentation, "pcie_ports=native", linux should use
> native AER and DPC services. While that is true for the _OSC method
> parsing, this is not the only place that is checked. Should the HEST
> table list PCIe ports as firmware-first, linux will not use native
> services.
>
> This happens because aer_acpi_firmware_first() doesn't take
> 'pcie_ports' into account. This is wrong. DPC uses the same logic when
> it decides whether to load or not, so fixing this also fixes DPC not
> loading.
>
> Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>

Applied to pci/aer for v4.19, thanks!

> ---
> drivers/pci/pcie/aer.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c
> index a2e88386af28..63a66a3b2fb5 100644
> --- a/drivers/pci/pcie/aer.c
> +++ b/drivers/pci/pcie/aer.c
> @@ -303,6 +303,9 @@ int pcie_aer_get_firmware_first(struct pci_dev *dev)
> if (!pci_is_pcie(dev))
> return 0;
>
> + if (pcie_ports_native)
> + return 0;
> +
> if (!dev->__aer_firmware_first_valid)
> aer_set_firmware_first(dev);
> return dev->__aer_firmware_first;
> @@ -323,6 +326,9 @@ bool aer_acpi_firmware_first(void)
> .firmware_first = 0,
> };
>
> + if (pcie_ports_native)
> + return 0;
> +
> if (!parsed) {
> apei_hest_parse(aer_hest_parse, &info);
> aer_firmware_first = info.firmware_first;
> --
> 2.14.3
>

\
 
 \ /
  Last update: 2018-07-11 01:20    [W:0.091 / U:1.708 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site