[lkml]   [2018]   [Jul]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[PATCH 4.14 082/157] auxdisplay: fix broken menu
4.14-stable review patch.  If anyone has any objections, please let me know.


From: Randy Dunlap <>

commit b5b903fba96a4d1771422efd5c713ebb73f7dc82 upstream.

Having the CHARLCD Kconfig symbol between "menuconfig AUXDISPLAY"
and "if AUXDISPLAY" breaks the AUXDISPLAY submenus, so move the
CHARLCD Kconfig symbol near the end of the file so that the menu
display is continuous.

Also include ARM_CHARLCD inside of the if AUXDISPLAY/endif block.
Geert says that it should be there.

Fixes: 39f8ea46724e ("auxdisplay: charlcd: Extract character LCD core from misc/panel")

Cc: # v4.12
Cc: Geert Uytterhoeven <>
Reviewed-by: Andy Shevchenko <>
Signed-off-by: Randy Dunlap <>
Signed-off-by: Miguel Ojeda <>
Signed-off-by: Greg Kroah-Hartman <>

drivers/auxdisplay/Kconfig | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)

--- a/drivers/auxdisplay/Kconfig
+++ b/drivers/auxdisplay/Kconfig
@@ -14,9 +14,6 @@ menuconfig AUXDISPLAY

If you say N, all options in this submenu will be skipped and disabled.

-config CHARLCD
- tristate "Character LCD core support" if COMPILE_TEST

config HD44780
@@ -157,8 +154,6 @@ config HT16K33
Say yes here to add support for Holtek HT16K33, RAM mapping 16*8
LED controller driver with keyscan.

bool "ARM Ltd. Character LCD Driver"
@@ -169,6 +164,8 @@ config ARM_CHARLCD
line and the Linux version on the second line, but that's
still useful.

config PANEL
tristate "Parallel port LCD/Keypad Panel support"
depends on PARPORT
@@ -448,3 +445,6 @@ config PANEL_BOOT_MESSAGE
printf()-formatted message is valid with newline and escape codes.

endif # PANEL
+config CHARLCD
+ tristate "Character LCD core support" if COMPILE_TEST

 \ /
  Last update: 2018-07-01 19:50    [W:0.533 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site