lkml.org 
[lkml]   [2018]   [Jul]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [1/3] ARM: dts: imx51-zii-common: create common include dtsi
On Wed, Jun 27, 2018 at 02:00:11PM -0300, Fabio Estevam wrote:
> On Wed, Jun 27, 2018 at 1:46 PM, Andrey Smirnov
> <andrew.smirnov@gmail.com> wrote:
>
> > We are now starting to give Andrey Gusakov conflicting
> > recommendations. For the sake of moving forward, can we agree that
> > this and similar comments are relatively minor and defer to the
> > maintainers to make a call which way to go?
> > This way Andrey has a clear way on how to move forward with this set.
>
> The approach in this patched looked fine to me as well.
>
> Maybe we can have some feedback from Shawn?

I'm overall fine with the approach as well. But I agree with Nikita's
comment that having pinctrl definition and usage spread in different
files makes reader's life harder. So I would suggest that we have the
following properties in imx51-zii-rdu1.dts as well.

pinctrl-names = "default";
pinctrl-0 = <&pinctrl_swi2c>;

Shawn

\
 
 \ /
  Last update: 2018-07-01 10:22    [W:0.065 / U:1.628 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site