[lkml]   [2018]   [Jul]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[PATCH 4.14 141/157] xen: Remove unnecessary BUG_ON from __unbind_from_irq()
4.14-stable review patch.  If anyone has any objections, please let me know.


From: Boris Ostrovsky <>

commit eef04c7b3786ff0c9cb1019278b6c6c2ea0ad4ff upstream.

Commit 910f8befdf5b ("xen/pirq: fix error path cleanup when binding
MSIs") fixed a couple of errors in error cleanup path of
xen_bind_pirq_msi_to_irq(). This cleanup allowed a call to
__unbind_from_irq() with an unbound irq, which would result in
triggering the BUG_ON there.

Since there is really no reason for the BUG_ON (xen_free_irq() can
operate on unbound irqs) we can remove it.

Reported-by: Ben Hutchings <>
Signed-off-by: Boris Ostrovsky <>
Reviewed-by: Juergen Gross <>
Signed-off-by: Juergen Gross <>
Signed-off-by: Greg Kroah-Hartman <>

drivers/xen/events/events_base.c | 2 --
1 file changed, 2 deletions(-)

--- a/drivers/xen/events/events_base.c
+++ b/drivers/xen/events/events_base.c
@@ -628,8 +628,6 @@ static void __unbind_from_irq(unsigned i

- BUG_ON(info_for_irq(irq)->type == IRQT_UNBOUND);

 \ /
  Last update: 2018-07-01 18:36    [W:0.480 / U:0.220 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site