lkml.org 
[lkml]   [2018]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v9 11/12] KVM: x86: Set intercept for Intel PT MSRs read/write
On Tue, May 22, 2018 at 12:52:14PM +0800, Luwei Kang wrote:
> From: Chao Peng <chao.p.peng@linux.intel.com>
>
> Disable intercept Intel PT MSRs only when Intel PT is
> enabled in guest. But MSR_IA32_RTIT_CTL will alway be
> intercept.

"I'd like to offer some suggestions as to how to make the commit message
friendlier for reviewing.

Generally, for every patch, we want to explain the following: what we want,
why we want it and how we want to go about getting it. We also would prefer
to do it in english rather than in C, because for the latter we can just
look at the code." [1]

I apologize for quoting myself or if I'm stating the obvious, but it looks
appropriate here.

[1] https://marc.info/?l=linux-kernel&m=152233031020263

Regards,
--
Alex

\
 
 \ /
  Last update: 2018-06-07 16:23    [W:0.145 / U:0.304 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site