lkml.org 
[lkml]   [2018]   [Jun]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] modsign: log module name in the event of an error
From
Date
On Fri, 2018-06-29 at 17:53 +0200, Jessica Yu wrote:
> Now that we have the load_info struct all initialized (including
> info->name, which contains the name of the module) before
> module_sig_check(), make the load_info struct and hence module name
> available to mod_verify_sig() so that we can log the module name in the
> event of an error.
[]
> diff --git a/kernel/module-internal.h b/kernel/module-internal.h
[]
> +extern int mod_verify_sig(const void *mod, struct load_info *info,
> + unsigned long *_modlen);
> diff --git a/kernel/module.c b/kernel/module.c
[]
> @@ -2778,7 +2758,7 @@ static int module_sig_check(struct load_info *info, int flags)
> memcmp(mod + info->len - markerlen, MODULE_SIG_STRING, markerlen) == 0) {
> /* We truncate the module to discard the signature */
> info->len -= markerlen;
> - err = mod_verify_sig(mod, &info->len);
> + err = mod_verify_sig(mod, info, &info->len);

This is the only place this is used correct?
So why pass info and info->member?

info should be enough


\
 
 \ /
  Last update: 2018-06-30 06:05    [W:0.054 / U:13.580 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site