[lkml]   [2018]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] dma: ste_dma40: Remove VLA usage
On Fri, Jun 29, 2018 at 8:51 PM, Kees Cook <> wrote:
> In the quest to remove all stack VLA usage from the kernel[1], this
> switches to using a pre-allocated scratch register space, set up with
> all other other allocations.
> [1]
> Cc: Linus Walleij <>
> Cc: Dan Williams <>
> Cc: Vinod Koul <>
> Cc:
> Cc:
> Signed-off-by: Kees Cook <>

I looked too long at this one, in short:

- Your change looks correct to me
- It could be done better in many ways, all of which would
involve cleaning up some of the existing code in the process
- Nobody uses this driver in practice, as the hardware platform
was a dead end

Reviewed-by: Arnd Bergmann <>

 \ /
  Last update: 2018-06-29 23:23    [W:0.069 / U:5.332 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site