[lkml]   [2018]   [Jun]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Subject[PATCH v7 00/11] track CPU utilization
This patchset initially tracked only the utilization of RT rq. During
OSPM summit, it has been discussed the opportunity to extend it in order
to get an estimate of the utilization of the CPU.

- Patches 1 move pelt code in a dedicated file and remove some blank lines

- Patches 2-3 add utilization tracking for rt_rq.

When both cfs and rt tasks compete to run on a CPU, we can see some frequency
drops with schedutil governor. In such case, the cfs_rq's utilization doesn't
reflect anymore the utilization of cfs tasks but only the remaining part that
is not used by rt tasks. We should monitor the stolen utilization and take
it into account when selecting OPP. This patchset doesn't change the OPP
selection policy for RT tasks but only for CFS tasks

A rt-app use case which creates an always running cfs thread and a rt threads
that wakes up periodically with both threads pinned on same CPU, show lot of
frequency switches of the CPU whereas the CPU never goes idles during the
test. I can share the json file that I used for the test if someone is
interested in.

For a 15 seconds long test on a hikey 6220 (octo core cortex A53 platfrom),
the cpufreq statistics outputs (stats are reset just before the test) :
$ cat /sys/devices/system/cpu/cpufreq/policy0/stats/total_trans
without patchset : 1230
with patchset : 14

If we replace the cfs thread of rt-app by a sysbench cpu test, we can see
performance improvements:

- Without patchset :
Test execution summary:
total time: 15.0009s
total number of events: 4903
total time taken by event execution: 14.9972
per-request statistics:
min: 1.23ms
avg: 3.06ms
max: 13.16ms
approx. 95 percentile: 12.73ms

Threads fairness:
events (avg/stddev): 4903.0000/0.00
execution time (avg/stddev): 14.9972/0.00

- With patchset:
Test execution summary:
total time: 15.0014s
total number of events: 7694
total time taken by event execution: 14.9979
per-request statistics:
min: 1.23ms
avg: 1.95ms
max: 10.49ms
approx. 95 percentile: 10.39ms

Threads fairness:
events (avg/stddev): 7694.0000/0.00
execution time (avg/stddev): 14.9979/0.00

The performance improvement is 56% for this use case.

- Patches 4-5 add utilization tracking for dl_rq in order to solve similar
problem as with rt_rq. Nevertheless, we keep using dl bandwidth as default
level of requirement for dl tasks. The dl utilization is used to check that
the CPU is not overloaded which is not always reflected when using dl

- Patches 6-7 add utilization tracking for interrupt and use it select OPP
A test with iperf on hikey 6220 gives:
w/o patchset w/ patchset
Tx 276 Mbits/sec 304 Mbits/sec +10%
Rx 299 Mbits/sec 328 Mbits/sec +09%

8 iterations of iperf -c server_address -r -t 5
stdev is lower than 1%
Only WFI idle state is enable (shallowest arm idle state)

- Patch 8 merges sugov_aggregate_util and sugov_get_util as proposed by Peter

- Patches 9 uses rt, dl and interrupt utilization in the scale_rt_capacity()
and remove the use of sched_rt_avg_update.

- Patches 10 removes the unused sched_avg_update code

- Patch 11 removes the unused sched_time_avg_ms

Change since v6:
- add more comments load tracking metrics
- merge sugov_aggregate_util and sugov_get_util

Change since v4:
- add support of periodic update of blocked utilization
- rebase on lastest tip/sched/core

Change since v3:
- add support of periodic update of blocked utilization
- rebase on lastest tip/sched/core

Change since v2:
- move pelt code into a dedicated pelt.c file
- rebase on load tracking changes

Change since v1:
- Only a rebase. I have addressed the comments on previous version in
patch 1/2

Vincent Guittot (11):
sched/pelt: Move pelt related code in a dedicated file
sched/rt: add rt_rq utilization tracking
cpufreq/schedutil: use rt utilization tracking
sched/dl: add dl_rq utilization tracking
cpufreq/schedutil: use dl utilization tracking
sched/irq: add irq utilization tracking
cpufreq/schedutil: take into account interrupt
sched: schedutil: remove sugov_aggregate_util()
sched: use pelt for scale_rt_capacity()
sched: remove rt_avg code
proc/sched: remove unused sched_time_avg_ms

include/linux/sched/sysctl.h | 1 -
kernel/sched/Makefile | 2 +-
kernel/sched/core.c | 38 +---
kernel/sched/cpufreq_schedutil.c | 65 ++++---
kernel/sched/deadline.c | 8 +-
kernel/sched/fair.c | 403 +++++----------------------------------
kernel/sched/pelt.c | 399 ++++++++++++++++++++++++++++++++++++++
kernel/sched/pelt.h | 72 +++++++
kernel/sched/rt.c | 15 +-
kernel/sched/sched.h | 68 +++++--
kernel/sysctl.c | 8 -
11 files changed, 632 insertions(+), 447 deletions(-)
create mode 100644 kernel/sched/pelt.c
create mode 100644 kernel/sched/pelt.h


 \ /
  Last update: 2018-06-28 17:46    [W:0.239 / U:1.760 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site