lkml.org 
[lkml]   [2018]   [Jun]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [1/3] ARM: dts: imx51-zii-common: create common include dtsi
Nikita:

Since you are mostly arguing against the suggestions I made to Andrey
Gusakov in off-list review, I'll respond.

On Wed, Jun 27, 2018 at 12:11 AM Nikita Yushchenko
<nikita.yoush@yandex.ru> wrote:
>
> > + i2c_gpio: i2c-gpio {
> > + compatible = "i2c-gpio";
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_swi2c>;
> > + i2c-gpio,delay-us = <50>;
> > + status = "okay";
> > +
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + };
>
> You add i2c-gpio node to dtsi file without defining gpios, with reference
> to pinctrl not defined inside your dtsi file or it's includes, and without
> any usage inside dtsi file.
>
> Saving several text lines that way is a bad idea.

There are three boards that share that configuration almost to a T,
with the only difference is the particular GPIOs used. Putting it into
a common file avoids repeating the boilerplate and makes it explicit
to the reader that those settings are shared.

> Please move it to where it is fully defined and used.
>

We are now starting to give Andrey Gusakov conflicting
recommendations. For the sake of moving forward, can we agree that
this and similar comments are relatively minor and defer to the
maintainers to make a call which way to go?
This way Andrey has a clear way on how to move forward with this set.

> > +&usb_vbus {
> > + regulator-always-on;
>
> usb_vbus is regilator-fixed, what for is this?
>
> > +&uart2 {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_uart2>;
> > + status = "okay";
> > +};
>
> In your further patches you include this and then revert by marking &uart2 as
> disabled. Better to enable it in dts for boards that have it.
>

There are at least two boards that use that UART2 as is. Same as above
this was done to reduce boilerplate.

> Same with ecspi2, ipu and maybe more.
>

Ditto.

> > - flash@1 {
> > - #address-cells = <1>;
> > - #size-cells = <1>;
> > - compatible = "atmel,at45db642d", "atmel,at45", "atmel,dataflash";
> > - spi-max-frequency = <25000000>;
> > - reg = <1>;
> > - };
>
> > + flash@1 {
> > + #address-cells = <1>;
> > + #size-cells = <1>;
> > + compatible = "atmel,at45", "atmel,dataflash";
> > + spi-max-frequency = <25000000>;
> > + reg = <1>;
> > + };
>
> Lost a compatible key?
>
> > - sysled0@3 {
> > - reg = <3>;
> > - label = "system:green:status";
> > - linux,default-trigger = "default-on";
> > - };
>
> > + sysled3: led3@3 {
> > + reg = <3>;
> > + label = "system:red:power";
> > + linux,default-trigger = "default-on";
> > + };
>
> > +&sysled3 {
> > + label = "system:green:status";
>
> What for this label games?

Same as above. Avoiding unnecessary repetitions.

Thanks,
Andrey Smirnov

\
 
 \ /
  Last update: 2018-06-27 18:47    [W:0.127 / U:1.432 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site