lkml.org 
[lkml]   [2018]   [Jun]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] dt-bindings: soc: qcom: Fix default clock-freq for qcom,geni-i2c
On Wed 13 Jun 10:50 PDT 2018, Douglas Anderson wrote:

> In an early version of the I2C patch that was posted to the list the
> default I2C frequency (if none was specified) was 400 kHz. There was
> debate on the list and we decided that it would be more consistent
> with the rest of i2c if we defaulted to 100 kHz. ...but we never
> updated the bindings. Let's fix this.
>
> NOTE: since the i2c driver itself hasn't actually landed yet and the
> SoC here is very new it seems terribly unlikely that anyone was
> relying on the old 400 kHz number, so I'll assume this is an OK
> "incompatible" device tree change.
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>

Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>

Regards,
Bjorn

> ---
>
> Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.txt b/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.txt
> index d330c73de9a2..68b7d6207e3d 100644
> --- a/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.txt
> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.txt
> @@ -39,7 +39,7 @@ Required properties:
>
> Optional property:
> - clock-frequency: Desired I2C bus clock frequency in Hz.
> - When missing default to 400000Hz.
> + When missing default to 100000Hz.
>
> Child nodes should conform to I2C bus binding as described in i2c.txt.
>
> --
> 2.18.0.rc1.244.gcf134e6275-goog
>

\
 
 \ /
  Last update: 2018-06-22 18:52    [W:0.090 / U:4.188 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site