lkml.org 
[lkml]   [2018]   [Jun]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2] fs: ocfs2: Adding new return type vm_fault_t
On Sat, Jun 2, 2018 at 5:17 AM, Andrew Morton <akpm@linux-foundation.org> wrote:
> On Wed, 23 May 2018 21:02:58 +0530 Souptick Joarder <jrdr.linux@gmail.com> wrote:
>
>> Use new return type vm_fault_t for fault handler. For
>> now, this is just documenting that the function returns
>> a VM_FAULT value rather than an errno. Once all instances
>> are converted, vm_fault_t will become a distinct type.
>>
>> Ref-> commit 1c8f422059ae ("mm: change return type to vm_fault_t")
>>
>> vmf_error() is the newly introduce inline function
>> in 4.18.
>>
>> Fix one checkpatch.pl warning by replacing BUG_ON()
>> with WARN_ON()
>
> err, no, I'll revert that part.
>
> It could be that if this assertion triggers then filesystem corruption
> would ensue, in which case a BUG_ON() is the appropriate handling.
> Such a change should be submitted separately, please.
>

In few places checkpatch.pl throwing warning to replace BUG_ON()
with WARN_ON(). Shall we ignore these warning or it will vary across
patches ?

\
 
 \ /
  Last update: 2018-06-02 08:17    [W:0.055 / U:6.496 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site