[lkml]   [2018]   [Jun]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v2 1/2] platform/x86: asus-wmi: Call led hw_changed API on kbd brightness change
On Tue, Jun 19, 2018 at 7:46 PM, Daniel Drake <> wrote:

>> > Can we avoid those ugly castings?

> Now kbd_led_set can continue being a correctly typed function pointer
> for led_classdev.brightness_set. And from the code you are adding here
> you can call __kbd_led_set directly with signed integer values, and
> rely on correct bounds correction without ugly casts.
> Andy, what do you think?

Thanks, Daniel for investigation.

I'm fine with solution(s) that has no ugly casting and no regression
on the hardware we support.

With Best Regards,
Andy Shevchenko

 \ /
  Last update: 2018-06-19 19:05    [W:0.116 / U:2.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site