Messages in this thread |  | | Date | Wed, 13 Jun 2018 23:18:59 -0700 | From | Christoph Hellwig <> | Subject | Re: [PATCH V6 00/30] block: support multipage bvec |
| |
On Thu, Jun 14, 2018 at 09:18:58AM +0800, Ming Lei wrote: > This one may cause confusing, since we iterate over pages via > bio_for_each_segment(), but the _all version takes another name > of page, still iterate over pages. > > So could we change it in the following way? > > OLD: bio_for_each_segment_all > NEW(page): bio_for_each_segment_all (update prototype in one tree-wide & > big patch, to be renamed bio_for_each_page_all) > NEW(bvec): (no bvec version needed once bcache is fixed up)
Fine with me, but I thought Jens didn't like that sweeping change?
|  |