lkml.org 
[lkml]   [2018]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 3/7] vmw_balloon: fix inflation of 64-bit GFNs
Date
at 11:21 AM, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:

> On Wed, Jun 13, 2018 at 04:03:55AM -0700, Nadav Amit wrote:
>> When balloon batching is not supported by the hypervisor, the guest
>> frame number (GFN) must fit in 32-bit. However, due to a bug, this check
>> was mistakenly ignored. In practice, when total RAM is greater than
>> 16TB, the balloon does not work currently, making this bug unlikely to
>> happen.
>>
>> Fixes: ef0f8f112984 ("VMware balloon: partially inline
>> vmballoon_reserve_page.")
>
> Why have a bugfix as the 3rd patch of the series? Please put it first,
> so that it can get into Linus's tree sooner.
>
> Also, no need to line-wrap this, and drop the blank line.
>
> And finally, does this need to go to the stable kernels? If so, please
> add the correct line for that.

I will fix the message. Patches 3-7 deal with minor bugs, some of which have
been there since day one, so I didn’t put a “Fixes” tag.

I’ll follow your direction and put patches 1-2 at the end.

\
 
 \ /
  Last update: 2018-06-13 20:28    [W:0.080 / U:2.224 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site