lkml.org 
[lkml]   [2018]   [Jun]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH -mm -V3 03/21] mm, THP, swap: Support PMD swap mapping in swap_duplicate()
Date
Daniel Jordan <daniel.m.jordan@oracle.com> writes:

> On Tue, Jun 12, 2018 at 09:23:19AM +0800, Huang, Ying wrote:
>> Daniel Jordan <daniel.m.jordan@oracle.com> writes:
>> >> +#else
>> >> +static inline int __swap_duplicate_cluster(swp_entry_t *entry,
>> >
>> > This doesn't need inline.
>>
>> Why not? This is just a one line stub.
>
> Forgot to respond to this. The compiler will likely choose to optimize out
> calls to an empty function like this. Checking, this is indeed what it does in
> this case on my machine, with or without inline.

Yes. I believe a decent compiler will inline the function in any way.
And it does no harm to keep "inline" too, Yes?

> By the way, when building without CONFIG_THP_SWAP, we get
>
> linux/mm/swapfile.c:933:13: warning: ‘__swap_free_cluster’ defined but not used [-Wunused-function]
> static void __swap_free_cluster(struct swap_info_struct *si, unsigned long idx)
> ^~~~~~~~~~~~~~~~~~~

Thanks! I will fix this. Don't know why 0-Day didn't catch this.

Best Regards,
Huang, Ying

\
 
 \ /
  Last update: 2018-06-13 03:27    [W:0.067 / U:3.284 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site