[lkml]   [2018]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
SubjectRe: [PATCH v2] fs: ocfs2: Adding new return type vm_fault_t
On Wed, 23 May 2018 21:02:58 +0530 Souptick Joarder <> wrote:

> Use new return type vm_fault_t for fault handler. For
> now, this is just documenting that the function returns
> a VM_FAULT value rather than an errno. Once all instances
> are converted, vm_fault_t will become a distinct type.
> Ref-> commit 1c8f422059ae ("mm: change return type to vm_fault_t")
> vmf_error() is the newly introduce inline function
> in 4.18.
> Fix one warning by replacing BUG_ON()
> with WARN_ON()

err, no, I'll revert that part.

It could be that if this assertion triggers then filesystem corruption
would ensue, in which case a BUG_ON() is the appropriate handling.
Such a change should be submitted separately, please.

--- a/fs/ocfs2/mmap.c~fs-ocfs2-adding-new-return-type-vm_fault_t-fix
+++ a/fs/ocfs2/mmap.c
@@ -120,7 +120,7 @@ static vm_fault_t __ocfs2_page_mkwrite(s
goto out;
err = ocfs2_write_end_nolock(mapping, pos, len, len, fsdata);
- WARN_ON(err != len);
+ BUG_ON(err != len);
return ret;
 \ /
  Last update: 2018-06-02 01:48    [W:0.051 / U:6.764 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site