lkml.org 
[lkml]   [2018]   [May]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V2 2/5] backlight: qcom-wled: Add support for WLED4 peripheral
On Thu, May 03, 2018 at 03:42:29PM +0530, Kiran Gunda wrote:
> WLED4 peripheral is present on some PMICs like pmi8998
> and pm660l. It has a different register map and also
> configurations are different. Add support for it.
>
> Signed-off-by: Kiran Gunda <kgunda@codeaurora.org>
> ---
> .../bindings/leds/backlight/qcom-wled.txt | 172 ++++-

Please split bindings to a separate patch.

This is also a whole lot of churn re-formatting. That is fine, but don't
mix actual changes to the binding with re-formatting. You can do 2
patches in this case:

- move and reformat (as long as the move shows up as a move
and not a remove and add)
- additions for new chips

> drivers/video/backlight/qcom-wled.c | 749 +++++++++++++++------
> 2 files changed, 696 insertions(+), 225 deletions(-)

\
 
 \ /
  Last update: 2018-05-07 18:46    [W:0.132 / U:0.980 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site