lkml.org 
[lkml]   [2018]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] driver-core: Return EBUSY error instead of BUG_ON()
On Fri, May 04, 2018 at 03:23:57PM +0200, Florian Schmaus wrote:
> I triggerd the BUG_ON() in driver_register(), which was added in
> f48f3febb2cbfd0f2ecee7690835ba745c1034a4, when booting a domU Xen
> domain. Since there was no contextual information logged, I needed to
> attach kgdb to determine the culprit (the wmi-bmof driver in my case).
>
> Instead of running into a BUG_ON() we print an error message
> identifying the driver but continue booting.
>
> Signed-off-by: Florian Schmaus <flo@geekplace.eu>
> ---
> drivers/base/driver.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>

What changed from v1? Always put that below the --- line.

Also, it's best to quote commits with the following format:
f48f3febb2cb ("driver-core: do not register a driver with bus_type not registered")

v3?

thanks,

greg k-h

\
 
 \ /
  Last update: 2018-05-04 19:38    [W:0.191 / U:8.468 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site