lkml.org 
[lkml]   [2018]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 07/10] PCI: Convert of_pci_get_host_bridge_resources() users to devm variant
On Thu, May 03, 2018 at 10:18:24AM +0300, Vladimir Zapolskiy wrote:
> Hi Jan,
>
> On 04/30/2018 08:48 AM, Jan Kiszka wrote:
> > From: Jan Kiszka <jan.kiszka@siemens.com>
> >
> > Straightforward for all of them, no more leaks afterwards.
> >
> > CC: Jingoo Han <jingoohan1@gmail.com>
> > CC: Joao Pinto <Joao.Pinto@synopsys.com>
> > CC: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> > Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> > Acked-by: Jingoo Han <jingoo1han@gmail.com>
>
> [snip]
>
> > diff --git a/drivers/pci/host/pcie-rcar.c b/drivers/pci/host/pcie-rcar.c
> > index 6ab28f29ac6a..6eb36c924983 100644
> > --- a/drivers/pci/host/pcie-rcar.c
> > +++ b/drivers/pci/host/pcie-rcar.c
> > @@ -1067,12 +1067,11 @@ static int rcar_pcie_parse_request_of_pci_ranges(struct rcar_pcie *pci)
> > {
> > int err;
> > struct device *dev = pci->dev;
> > - struct device_node *np = dev->of_node;
> > resource_size_t iobase;
> > struct resource_entry *win, *tmp;
> >
> > - err = of_pci_get_host_bridge_resources(np, 0, 0xff, &pci->resources,
> > - &iobase);
> > + err = devm_of_pci_get_host_bridge_resources(dev, 0, 0xff,
> > + &pci->resources, &iobase);
> > if (err)
> > return err;
> >
>
> this one snippet is obsoleted by https://patchwork.ozlabs.org/patch/904326/
>
> If 08/10 remains a deprecation, then it is sufficient to exclude the R-Car change,
> otherwise I hope maintainers can deal with the proper ordering.

Isn't applying your patch:

https://patchwork.ozlabs.org/patch/904326/

and dropping the rcar hunk from this patch enough ?

Lorenzo

\
 
 \ /
  Last update: 2018-05-04 18:44    [W:2.795 / U:2.260 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site