lkml.org 
[lkml]   [2018]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/3] kcov: prefault the kcov_area
From
Date


On 05/04/2018 05:38 PM, Mark Rutland wrote:
> On Fri, May 04, 2018 at 05:36:49PM +0300, Andrey Ryabinin wrote:
>>
>>
>> On 05/04/2018 04:55 PM, Mark Rutland wrote:
>>
>>>
>>> +static void kcov_fault_in_area(struct kcov *kcov)
>>> +{
>>> + unsigned long stride = PAGE_SIZE / sizeof(unsigned long);
>>> + unsigned long *area = kcov->area;
>>> + unsigned long offset;
>>> +
>>> + for (offset = 0; offset < kcov->size; offset += stride) {
>>> + READ_ONCE(area[offset]);
>>> + }
>>
>> Usually we don't use {} for a single statement blocks.
>>
>>> +}
>>> +
>
> I'll remove the braces.
>
> Can I consider that an ack, otherwise? :)

Yes, ack for all 3 patches.


>
> Thanks,
> Mark.
>

\
 
 \ /
  Last update: 2018-05-04 16:42    [W:0.047 / U:2.440 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site