lkml.org 
[lkml]   [2018]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ARM: dts: imx6sx-sabreauto: add egalax touch screen support
On Fri, Apr 27, 2018 at 03:20:50PM +0800, Anson Huang wrote:
> From: Haibo Chen <haibo.chen@nxp.com>
>
> Add egalax touch screen support on i2c2 bus.
>
> Signed-off-by: Haibo Chen <haibo.chen@freescale.com>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
> this patch is based on patch (ARM: dts: imx6sx-sabreauto: add debug LED support) I sent out for review.
> arch/arm/boot/dts/imx6sx-sabreauto.dts | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx6sx-sabreauto.dts b/arch/arm/boot/dts/imx6sx-sabreauto.dts
> index 6b94f24..2f6e474 100644
> --- a/arch/arm/boot/dts/imx6sx-sabreauto.dts
> +++ b/arch/arm/boot/dts/imx6sx-sabreauto.dts
> @@ -131,6 +131,12 @@
> &iomuxc {
> imx6x-sabreauto {
>
> + pinctrl_egalax_int: egalax_intgrp {

General recommendation: use hyphen instead of underscore in the node
node.

> + fsl,pins = <
> + MX6SX_PAD_SD4_RESET_B__GPIO6_IO_22 0x80000000
> + >;
> + };
> +
> pinctrl_led: ledgrp {
> fsl,pins = <
> MX6SX_PAD_CSI_PIXCLK__GPIO1_IO_24 0x17059
> @@ -274,6 +280,16 @@
> pinctrl-0 = <&pinctrl_i2c2_1>;
> status = "okay";
>
> + egalax_ts@04 {

Use generic node name - touchscreen, as recommended by Devicetree
Specification, and drop leading zeros in unit-address.

Shawn

> + compatible = "eeti,egalax_ts";
> + reg = <0x04>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_egalax_int>;
> + interrupt-parent = <&gpio6>;
> + interrupts = <22 IRQ_TYPE_EDGE_FALLING>;
> + wakeup-gpios = <&gpio6 22 GPIO_ACTIVE_HIGH>;
> + };
> +
> max7322: gpio@68 {
> compatible = "maxim,max7322";
> reg = <0x68>;
> --
> 2.7.4
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

\
 
 \ /
  Last update: 2018-05-04 10:28    [W:0.046 / U:3.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site