lkml.org 
[lkml]   [2018]   [May]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 5/6] ARM: dts: Add generic interconnect target module node for MCAN
From
Date
Hi,

On Wednesday 30 May 2018 08:34 PM, Tony Lindgren wrote:
> * Faiz Abbas <faiz_abbas@ti.com> [180530 14:12]:
>> The ti-sysc driver provides support for manipulating the idlemodes
>> and interconnect level resets.
> ...
>> --- a/arch/arm/boot/dts/dra76x.dtsi
>> +++ b/arch/arm/boot/dts/dra76x.dtsi
>> @@ -11,6 +11,25 @@
>> / {
>> compatible = "ti,dra762", "ti,dra7";
>>
>> + ocp {
>> +
>> + target-module@0x42c00000 {
>> + compatible = "ti,sysc-dra7-mcan";
>> + ranges = <0x0 0x42c00000 0x2000>;
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + reg = <0x42c01900 0x4>,
>> + <0x42c01904 0x4>,
>> + <0x42c01908 0x4>;
>> + reg-names = "rev", "sysc", "syss";
>> + ti,sysc-mask = <(SYSC_OMAP4_SOFTRESET |
>> + SYSC_DRA7_MCAN_ENAWAKEUP)>;
>> + ti,syss-mask = <1>;
>> + clocks = <&wkupaon_clkctrl DRA7_ADC_CLKCTRL 0>;
>> + clock-names = "fck";
>> + };
>> + };
>> +
>> };
>
> Looks good to me except I think the reset won't do anything currently
> with ti-sysc.c unless you specfify also "ti,hwmods" for the module?
>
> Can you please check? It might be worth adding the reset function to
> ti-sysc.c for non "ti,hwmods" case and that just might remove the
> need for any hwmod code for this module.
>

If I understand correctly, this involves adding a (*reset_module) in
ti_sysc_platform_data and defining a ti_sysc_reset_module() in ti-sysc.c
similar to ti_sysc_idle_module(). Right?

Thanks,
Faiz

\
 
 \ /
  Last update: 2018-05-31 12:20    [W:0.119 / U:1.820 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site