[lkml]   [2018]   [May]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 16/28] ovl: Do not expose metacopy only dentry from d_real()
On Thu, May 31, 2018 at 12:05 AM, Vivek Goyal <> wrote:
> On Tue, May 29, 2018 at 04:46:00PM +0200, Miklos Szeredi wrote:
>> From: Vivek Goyal <>
>> Metacopy dentry/inode is internal to overlay and is never exposed outside
>> of it. Exception is metacopy upper file used for fsync(). Modify d_real()
>> to look for dentries/inode which have data, but also allow matching upper
>> inode without data for the fsync case.
> Hi Miklos,
> I am not able to see how in fsync() path d_real() gets called. If we
> decide to do fsync() on upper metacopy, then opening upper will not
> go through d_real(). And we never issue fsync() on lower.
> So I am scratching my head while trying to understand the d_real() and
> fsync() connection.

fsync() exposes real meta inode to vfs, so file_dentry() needs to
be able to find the real meta upper dentry.


 \ /
  Last update: 2018-05-31 06:31    [W:0.062 / U:4.212 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site