lkml.org 
[lkml]   [2018]   [May]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 10/19 v3] regulator: s2mps11: Pass descriptor instead of GPIO number
On Mon, May 28, 2018 at 2:26 PM, Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Mon, May 28, 2018 at 2:29 PM, Bartlomiej Zolnierkiewicz
> <b.zolnierkie@samsung.com> wrote:
>
>> - s2mps11->ext_control_gpiod = devm_kmalloc(&pdev->dev,
>> + s2mps11->ext_control_gpiod = devm_kzalloc(&pdev->dev,
>> sizeof(*s2mps11->ext_control_gpiod) * rdev_num,
>> GFP_KERNEL);
>
> devm_kcalloc() I would rather use.

The patch replace kmalloc with kzalloc amd kcalloc does not initialize
memory to zero.

We don't have demv_kzcalloc() I'm afraid, I wonder it even makes
sense to add?

Yours,
Linus Walleij

\
 
 \ /
  Last update: 2018-05-30 09:11    [W:0.145 / U:1.400 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site