lkml.org 
[lkml]   [2018]   [May]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 5/6] soc: qcom: rpmh powerdomain driver
From
Date
[]...

>>> +Required Properties:
>>> + - compatible: Should be one of the following
>>> + * qcom,sdm845-rpmhpd: RPMh powerdomain for the sdm845 family of SoC
>>> + - power-domain-cells: number of cells in power domain specifier
>>> + must be 1
>>> + - operating-points-v2: Phandle to the OPP table for the power-domain.
>>> + Refer to Documentation/devicetree/bindings/power/power_domain.txt
>>> + and Documentation/devicetree/bindings/opp/qcom-opp.txt for more details
>>> +
>>> +Example:
>>> +
>>> + rpmhpd: power-controller {
>>> + compatible = "qcom,sdm845-rpmhpd";
>>> + #power-domain-cells = <1>;
>>> + operating-points-v2 = <&rpmhpd_opp_table>,
>>> + <&rpmhpd_opp_table>,
>>> + <&rpmhpd_opp_table>,
>>> + <&rpmhpd_opp_table>,
>>> + <&rpmhpd_opp_table>,
>>> + <&rpmhpd_opp_table>,
>>> + <&rpmhpd_opp_table>,
>>> + <&rpmhpd_opp_table>,
>>> + <&rpmhpd_opp_table>;
>>
>> Can this be changed to simply:
>> operating-points-v2 = <&rpmhpd_opp_table>;
>>
>> The opp binding documentation [1] states that this should be ok:
>>
>> If only one phandle is available, then the same OPP table will be used
>> for all power domains provided by the power domain provider.
>
> thanks, I mentioned this to Viresh but didn't realize he fixed it up.
> Will remove the redundant entries.

Looks like the kernel implementation does not handle this yet, and I get
an error adding the OPP tables for the powerdomains if I just specify
a single OPP table phandle.

Viresh, is this expected with the latest patches in linux-next?

It would be good if I can specify just one phandle instead of coping
the same phandle n times.

--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation

\
 
 \ /
  Last update: 2018-05-30 10:56    [W:1.574 / U:0.832 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site