lkml.org 
[lkml]   [2018]   [May]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] usb: dwc3: qcom: mark PM functions as __maybe_unused
Hi,

On Fri, May 25, 2018 at 9:06 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> The #ifdef guards around these are wrong, resulting in warnings
> in certain configurations:
>
> drivers/usb/dwc3/dwc3-qcom.c:244:12: error: 'dwc3_qcom_resume' defined but not used [-Werror=unused-function]
> static int dwc3_qcom_resume(struct dwc3_qcom *qcom)
> ^~~~~~~~~~~~~~~~
> drivers/usb/dwc3/dwc3-qcom.c:223:12: error: 'dwc3_qcom_suspend' defined but not used [-Werror=unused-function]
> static int dwc3_qcom_suspend(struct dwc3_qcom *qcom)
>
> This replaces the guards with __maybe_unused annotations to shut up
> the warnings and give better compile time coverage.
>
> Fixes: a4333c3a6ba9 ("usb: dwc3: Add Qualcomm DWC3 glue driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/usb/dwc3/dwc3-qcom.c | 12 ++++--------
> 1 file changed, 4 insertions(+), 8 deletions(-)

FWIW:

Reviewed-by: Douglas Anderson <dianders@chromium.org>

\
 
 \ /
  Last update: 2018-05-31 01:01    [W:0.071 / U:5.748 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site