lkml.org 
[lkml]   [2018]   [May]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] mtd: chips: Replace printk() with pr_*()
On Sat, 24 Mar 2018 22:01:45 +0530
Arushi Singhal <arushisinghal19971997@gmail.com> wrote:

> Using pr_<loglevel>() is more concise than printk(KERN_<LOGLEVEL>).
> This patch:
> * Replace printks having a log level with the appropriate
> pr_*() macros.
> * Indent the code where possible.
> * Remove periods from messages.
>
> Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
> ---
> changes:
> Before printk() is changes to dev_*macro(), but it was not good idea
> because mtd->dev is only initialized after mtd_device_register() is called.
>
> drivers/mtd/chips/cfi_cmdset_0001.c | 130 +++++++++++++++++++-----------------

I see printk(KERN_ ...) in other files inside this directory. This
should be fixed too.

\
 
 \ /
  Last update: 2018-05-03 12:03    [W:0.044 / U:4.204 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site