lkml.org 
[lkml]   [2018]   [May]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] autofs: make autofs4 and autofs mutually exclusive
Date
The autofs4 implementation is just a redirect to autofs now, but that
also means we can't have both built into the same kernel:

fs/autofs/inode.o: In function `autofs_new_ino':
inode.c:(.text+0x1b8): multiple definition of `autofs_new_ino'
fs/autofs/inode.o:inode.c:(.text+0x1b8): first defined here
fs/autofs/inode.o: In function `autofs_clean_ino':
inode.c:(.text+0x288): multiple definition of `autofs_clean_ino'

There is also a problem with trying to build both in parallel, which
leads to two 'make' processes writing to the same fs/autofs/.*.o.cmd
file, causing corruption that manifests like

fs/autofs4/../autofs/.expire.o.cmd:679: *** missing separator. Stop.

Making AUTOFS4_FS depend on AUTOFS_FS being disabled should avoid all
configurations that run into either issue.

Fixes: mmotm ("autofs: update fs/autofs4/Makefile")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
fs/autofs4/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/fs/autofs4/Kconfig b/fs/autofs4/Kconfig
index 53bc592a250d..eccf673c6c8c 100644
--- a/fs/autofs4/Kconfig
+++ b/fs/autofs4/Kconfig
@@ -1,5 +1,6 @@
config AUTOFS4_FS
tristate "Kernel automounter version 4 support (also supports v3 and v5)"
+ depends on AUTOFS_FS=n
default n
help
The automounter is a tool to automatically mount remote file systems
--
2.9.0
\
 
 \ /
  Last update: 2018-05-29 11:47    [W:0.095 / U:1.484 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site