lkml.org 
[lkml]   [2018]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 0/1] Remove the check of duplicate processors
On Thu, May 17, 2018 at 11:46 AM, Dou Liyang <douly.fnst@cn.fujitsu.com> wrote:
> There is a bug in CPU hotplug code, I have two simple fix method, but I can't
> ensure which one is better. So sent it out, seek help.
>
> We found some processors which have the same processor ID but in different
> PXM in ACPI namespace. such as this:
>
> proc_id | pxm
> --------------------
> 0 <-> 0
> 1 <-> 0
> 2 <-> 1
> 3 <-> 1
> ......
> 89 <-> 0
> 89 <-> 1
> 89 <-> 2
> 89 <-> 3
> ......
>
> So we create a mechanism to validate them. make the processor(ID=89)
> as invalid. And once a processor be hotplugged physically, we check its
> processor id.
>
> Commit 8e089eaa1999 ("acpi: Provide mechanism to validate processors in the ACPI tables")
> Commit a77d6cd96849 ("acpi/processor: Check for duplicate processor ids at hotplug time")
>
> Recently, I found the check mechanism has a bug, it didn't use the
> acpi_processor_ids_walk() right and always gave us a wrong result.
> First, I fixed it by modifying the value with AE_OK which is the
> standard acpi_status value.
>
> https://lkml.org/lkml/2018/3/20/273
>
> But, now, I even think this check is useless. my reasons are following:
>
> 1). Based on the practical effect, It works well, and no bug be reported
> 2). Based on the code, the duplicate cases can be dealed with by
>
> if (invalid_logical_cpuid(pr->id) || !cpu_present(pr->id))
>
> That seems more reasonable, let's see the following case:
>
> Before the patch, After the patch
>
> the first processor(ID=89)
> hot-add failed success
>
> the others processor(ID=89)
> hot-add failed failed
>
>
> So, What's your idea about it.
>
> Dou Liyang (1):
> acpi/processor: Remove the check of duplicates processor ids

Can you please resend the patch with the above information in the
changelog of it?

That would make it easier to review and discuss it.

Also I think that we need some sort of a check against duplicate IDs.

\
 
 \ /
  Last update: 2018-05-28 10:42    [W:0.093 / U:26.908 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site