lkml.org 
[lkml]   [2018]   [May]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] fixup! kconfig: refactor ncurses package checks for building mconf and nconf
From
Date
On 05/22/2018 07:11 PM, Masahiro Yamada wrote:
> It is redundant to pass -DNCURSES_WIDECHAR=1 explicitly; when we use
> 'pkg-config --cflags', it takes care of appropriate flags.
>
> Actually, 'pkg-config --cflags' will add -D_GNU_SOURCE, which will
> define _XOPEN_SOURCE_EXTENDED, and NCURSES_WIDECHAR=1, anyway.
>
> I added -D_GNU_SOURCE to follow the suggestion of pkg-config
> for cases where pkg-config is not useful.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> The v3 (https://patchwork.kernel.org/patch/10417413/) was
> reviewed and tested.
>
> I'd like to squash this into it.

Sure. Works for me. Thanks.

>
>
> scripts/kconfig/mconf-cfg.sh | 8 ++++----
> scripts/kconfig/nconf-cfg.sh | 7 ++++---
> 2 files changed, 8 insertions(+), 7 deletions(-)


--
~Randy

\
 
 \ /
  Last update: 2018-05-23 23:08    [W:0.059 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site