lkml.org 
[lkml]   [2018]   [May]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/6] coresight: remove CORESIGHT_LINKS_AND_SINKS dependencies and selections
On Tue, 22 May 2018 11:31:40 -0600
Mathieu Poirier <mathieu.poirier@linaro.org> wrote:

> On Thu, May 17, 2018 at 08:20:19PM -0500, Kim Phillips wrote:
> > A coresight topology doesn't need to include links, i.e., a source can
> > be directly connected to a sink. As such, selecting and/or depending on
> > LINKS_AND_SINKS is no longer needed.
>
> I'm good with this patch but now the help text for CORESIGHT_LINKS_AND_SINKS no
> longer match what the config does. I see two ways to fix this:

This patch doesn't change what the config does, it just changes what
other config options depend on it.

> 1) Rework the help text.

I don't see how, given the above. Here's the text:

config CORESIGHT_LINKS_AND_SINKS
bool "CoreSight Link and Sink drivers"
help
This enables support for CoreSight link and sink drivers that are
responsible for transporting and collecting the trace data
respectively. Link and sinks are dynamically aggregated with a trace
entity at run time to form a complete trace path.

What part of that becomes invalid with this patch?

> 2) Rework CORESIGHT_LINKS_AND_SINKS to be CORESIGHT_FUNNEL and move
> coresight-replicator.o under CORESIGHT_DYNAMIC_REPLICATOR in the Makefile. I
> really liked your idea of making the replicator driver intelligent enough to
> deal with both DT and platform declaration, which merges two driver into one.
>
> I'm obviously favouring the second option but recognise it doesn't have to be
> part of this patchet. So for this set please rework the help text for
> CORESIGHT_LINKS_AND_SINKS. Once we've dealt with this topic we can refactor the
> replicator driver.

I'd really like to just focus on getting CoreSight to load as modules,
something for which this patch isn't technically required...

Thanks,

Kim

\
 
 \ /
  Last update: 2018-05-23 21:52    [W:0.163 / U:0.464 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site