[lkml]   [2018]   [May]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 01/14] memory: ti-emif-sram: Add resume function to recopy sram code

On 5/23/2018 1:47 AM, Keerthy wrote:
> On Monday 16 April 2018 03:59 PM, Keerthy wrote:

>>> Instead of this indirect method , why can't just check the previous
>>> deep sleep mode and based on that do copy or not. EMIF power status
>>> register should have something like that ?
>> I will check if we have a register that tells the previous state of sram.
> Unfortunately i do not see any such register for knowing SRAM previous
> state in am43 TRM and hence this indirect way of knowing.

>>> Another minor point is even though there is nothing to do in suspend,
>>> might be good to have a callback with comment that nothing to do with
>>> some explanation why not. Don't have strong preference but may for
>>> better readability.
> I can add a blank suspend call with comment
> "The contents are already present in DDR hence no need to explicitly save"
> The comment in resume function pretty much explains the above. So let me
> know if i need to add the suspend callback.
> Please add the empty suspend callback with comment.


 \ /
  Last update: 2018-05-23 18:44    [W:0.055 / U:1.892 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site