lkml.org 
[lkml]   [2018]   [May]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC/RFT PATCH] ASoC: topology: Improve backwards compatibility with v4 topology files
On Wed, May 23, 2018 at 08:54:18AM -0700, Guenter Roeck wrote:
> On Wed, May 23, 2018 at 6:56 AM Mark Brown <broonie@kernel.org> wrote:
> > On Wed, May 23, 2018 at 03:54:54PM +0200, Takashi Iwai wrote:

> > > And I'm wondering whether we should move these definitions to uapi
> > > headers.

> > Yes, we should.

> Are you sure ? They used to be in
> sound/soc/intel/skylake/skl-tplg-interface.h.
> I took my clue from sound/soc/soc-topology.c, where the v4 structures are
> also
> declared locally and not in the uapi files.

I'm saying we should move them there. They're clearly part of the
userspace ABI and therefore belong in uapi, it was a mistake to let them
be elsewhere.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2018-05-23 17:58    [W:0.076 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site