lkml.org 
[lkml]   [2018]   [May]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RESEND PATCH] PCI: qcom: add runtime pm support to pcie_port
From
Date


On 23/05/18 07:15, Vinod wrote:
> On 18-05-18, 00:07, Bjorn Andersson wrote:
>
>> diff --git a/drivers/pci/dwc/pcie-qcom.c b/drivers/pci/dwc/pcie-qcom.c
>> index 5897af7d3355..3f35098b71b1 100644
>> --- a/drivers/pci/dwc/pcie-qcom.c
>> +++ b/drivers/pci/dwc/pcie-qcom.c
>> @@ -1088,6 +1088,8 @@ static int qcom_pcie_host_init(struct pcie_port *pp)
>> struct qcom_pcie *pcie = to_qcom_pcie(pci);
>> int ret;
>>
>> + pm_runtime_get_sync(pci->dev);
>> +
>> qcom_ep_reset_assert(pcie);
>>
>> ret = pcie->ops->init(pcie);
>> @@ -1124,6 +1126,7 @@ static int qcom_pcie_host_init(struct pcie_port *pp)
>> phy_power_off(pcie->phy);
>> err_deinit:
>> pcie->ops->deinit(pcie);
>> + pm_runtime_put_sync(pci->dev);
>
> Wondering if there is a reason for sync put here?
pm_runtime_get_sync() call paired with a pm_runtime_put() call will be
appropriate here I guess as per
https://www.kernel.org/doc/Documentation/power/runtime_pm.txt

I will respin this patch.

Thanks,
srini


>

\
 
 \ /
  Last update: 2018-05-23 12:11    [W:0.050 / U:1.488 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site