[lkml]   [2018]   [May]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] gpio: pca953x: Clear irq trigger type on irq shutdown
On Fri, May 4, 2018 at 6:53 PM, Grigoryev Denis <> wrote:

> The driver stores the result of irq_set_type() in the internal variables
> irq_trig_raise and irq_trig_fall, which later are used to determine
> the GPIOs that must be re-configured as input. These variables retain their
> value between gpiolib's export / unexport, resulting in an incorrect
> state in some cases. The corresponding bits in the variables
> irq_trig_raise and irq_trig_fall should be cleared in irq_shutdown().
> Signed-off-by: Denis Grigoryev <>

Patch applied with Andy's ACK.

If there are issues we can just revert it.

Linus Walleij

 \ /
  Last update: 2018-05-23 11:49    [W:0.079 / U:0.352 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site