lkml.org 
[lkml]   [2018]   [May]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/6] proc: commit to genradix
On Wed, May 23, 2018 at 04:28:23AM -0700, Matthew Wilcox wrote:
> On Tue, May 22, 2018 at 09:18:17PM -0400, Kent Overstreet wrote:
> > @@ -2140,11 +2140,12 @@ proc_map_files_readdir(struct file *file, struct dir_context *ctx)
> > struct task_struct *task;
> > struct mm_struct *mm;
> > unsigned long nr_files, pos, i;
> > - struct flex_array *fa = NULL;
> > - struct map_files_info info;
> > + GENRADIX(struct map_files_info) fa;
> > struct map_files_info *p;
> > int ret;
> >
> > + genradix_init(&fa);
>
> Could we have a DEFINE_GENRADIX(type, name) which initialises the tree?

Already exists. I kind of prefer not to use it when I don't need to though, and
stick to things that look more like normal declarations instead.

\
 
 \ /
  Last update: 2018-05-24 00:19    [W:0.062 / U:0.640 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site