lkml.org 
[lkml]   [2018]   [May]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mm/THP: use hugepage_vma_check() in khugepaged_enter_vma_merge()
On Mon, 21 May 2018, Song Liu wrote:

> khugepaged_enter_vma_merge() is using a different approach to check
> whether a vma is valid for khugepaged_enter():
>
> if (!vma->anon_vma)
> /*
> * Not yet faulted in so we will register later in the
> * page fault if needed.
> */
> return 0;
> if (vma->vm_ops || (vm_flags & VM_NO_KHUGEPAGED))
> /* khugepaged not yet working on file or special mappings */
> return 0;
>
> This check has some problems. One of the obvious problems is that
> it doesn't check shmem_file(), so that vma backed with shmem files
> will not call khugepaged_enter().
>
> This patch fixes these problems by reusing hugepage_vma_check() in
> khugepaged_enter_vma_merge().
>
> Signed-off-by: Song Liu <songliubraving@fb.com>

Acked-by: David Rientjes <rientjes@google.com>

\
 
 \ /
  Last update: 2018-05-22 00:11    [W:0.061 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site