[lkml]   [2018]   [May]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[PATCH 4.16 044/110] bcache: return 0 from bch_debug_init() if CONFIG_DEBUG_FS=n
4.16-stable review patch.  If anyone has any objections, please let me know.


From: Coly Li <>

commit 1c1a2ee1b53b006754073eefc65d2b2cedb5264b upstream.

Commit 539d39eb2708 ("bcache: fix wrong return value in bch_debug_init()")
returns the return value of debugfs_create_dir() to bcache_init(). When
CONFIG_DEBUG_FS=n, bch_debug_init() always returns 1 and makes
bcache_init() failedi.

This patch makes bch_debug_init() always returns 0 if CONFIG_DEBUG_FS=n,
so bcache can continue to work for the kernels which don't have debugfs

v4: Add Acked-by from Kent Overstreet.
v3: Use IS_ENABLED(CONFIG_DEBUG_FS) to replace #ifdef DEBUG_FS.
v2: Remove a warning information
v1: Initial version.

Fixes: Commit 539d39eb2708 ("bcache: fix wrong return value in bch_debug_init()")
Signed-off-by: Coly Li <>
Reported-by: Massimo B. <>
Reported-by: Kai Krakow <>
Tested-by: Kai Krakow <>
Acked-by: Kent Overstreet <>
Signed-off-by: Jens Axboe <>
Signed-off-by: Kai Krakow <>
Signed-off-by: Greg Kroah-Hartman <>

drivers/md/bcache/debug.c | 3 +++
1 file changed, 3 insertions(+)

--- a/drivers/md/bcache/debug.c
+++ b/drivers/md/bcache/debug.c
@@ -251,6 +251,9 @@ void bch_debug_exit(void)

int __init bch_debug_init(struct kobject *kobj)
+ return 0;
debug = debugfs_create_dir("bcache", NULL);

return IS_ERR_OR_NULL(debug);

 \ /
  Last update: 2018-05-21 23:47    [W:0.491 / U:1.860 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site