lkml.org 
[lkml]   [2018]   [May]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v4 05/31] kconfig: remove string expansion for mainmenu after yyparse()
2018-05-20 23:39 GMT+09:00 Sam Ravnborg <sam@ravnborg.org>:

>> @@ -544,10 +530,10 @@ void conf_parse(const char *name)
>> if (!modules_sym)
>> modules_sym = sym_find( "n" );
>>
>> - tmp = rootmenu.prompt->text;
>> - rootmenu.prompt->text = _(rootmenu.prompt->text);
>> - rootmenu.prompt->text = sym_expand_string_value(rootmenu.prompt->text);
>> - free((char*)tmp);
>> + if (!menu_has_prompt(&rootmenu)) {
>> + current_entry = &rootmenu;
>> + menu_add_prompt(P_MENU, "Linux Kernel Configuration", NULL);
>
> Could this be something less specific?
> To help the other users of kconfig out is the wild.
>
> For example:
>
> menu_add_prompt(P_MENU, _("Main menu"), NULL);


OK, but this should be done as a separate work.

I am keeping the current string "Linux Kernel Configuration"



> Note, the added _() to make the text translateable.
>

Hmm, I just wonder how much helpful gettext things are...

Rather, it looks maintenance burden to me.
Once we add messages, it is difficult to change.


--
Best Regards
Masahiro Yamada

\
 
 \ /
  Last update: 2018-05-21 07:41    [W:0.084 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site