lkml.org 
[lkml]   [2018]   [May]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 01/11] media: tm6000: fix potential Spectre variant 1
From
Date


On 05/17/2018 01:08 PM, Gustavo A. R. Silva wrote:
>
> BTW, Mauro, you sent a patch to fix an spectre v1 issue in this file
> yesterday: dvb_ca_en50221.c:1480, but it seems there is another instance
> of the same issue some lines above:
>
> diff --git a/drivers/media/dvb-core/dvb_ca_en50221.c
> b/drivers/media/dvb-core/dvb_ca_en50221.c
> index 1310526..7edd9db 100644
> --- a/drivers/media/dvb-core/dvb_ca_en50221.c
> +++ b/drivers/media/dvb-core/dvb_ca_en50221.c
> @@ -1398,6 +1398,7 @@ static int dvb_ca_en50221_io_do_ioctl(struct file
> *file,
>
>                 info->type = CA_CI_LINK;
>                 info->flags = 0;
> +               slot = array_index_nospec(slot, ca->slot_count + 1);
>                 sl = &ca->slot_info[slot];
>                 if ((sl->slot_state != DVB_CA_SLOTSTATE_NONE) &&
>                     (sl->slot_state != DVB_CA_SLOTSTATE_INVALID)) {
>
>

Hi Mauro,

Just to let you know, I was running smatch during the weekend and the
tool is still reporting all these Spectre media warnings (and a lot more):

https://patchwork.linuxtv.org/project/linux-media/list/?submitter=7277

Thanks
--
Gustavo

\
 
 \ /
  Last update: 2018-05-21 18:19    [W:0.134 / U:3.452 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site