lkml.org 
[lkml]   [2018]   [May]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 07/29] venus: hfi_venus: add halt AXI support for Venus 4xx
From
Date
Hi Tomasz,

On 05/18/2018 05:23 PM, Tomasz Figa wrote:
> On Tue, May 15, 2018 at 5:12 PM Stanimir Varbanov <
> stanimir.varbanov@linaro.org> wrote:
>
>> Add AXI halt support for version 4xx by using venus wrapper
>> registers.
>
>> Signed-off-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>
>> ---
>> drivers/media/platform/qcom/venus/hfi_venus.c | 17 +++++++++++++++++
>> 1 file changed, 17 insertions(+)
>
>> diff --git a/drivers/media/platform/qcom/venus/hfi_venus.c
> b/drivers/media/platform/qcom/venus/hfi_venus.c
>> index 734ce11b0ed0..53546174aab8 100644
>> --- a/drivers/media/platform/qcom/venus/hfi_venus.c
>> +++ b/drivers/media/platform/qcom/venus/hfi_venus.c
>> @@ -532,6 +532,23 @@ static int venus_halt_axi(struct venus_hfi_device
> *hdev)
>> u32 val;
>> int ret;
>
>> + if (hdev->core->res->hfi_version == HFI_VERSION_4XX) {
>> + val = venus_readl(hdev, WRAPPER_CPU_AXI_HALT);
>> + val |= BIT(16);
>
> Can we have the bit defined?
>
>> + venus_writel(hdev, WRAPPER_CPU_AXI_HALT, val);
>> +
>> + ret = readl_poll_timeout(base +
> WRAPPER_CPU_AXI_HALT_STATUS,
>> + val, val & BIT(24),
>
> Ditto.

Sure will add defines.

--
regards,
Stan

\
 
 \ /
  Last update: 2018-05-21 14:17    [W:0.076 / U:1.396 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site