lkml.org 
[lkml]   [2018]   [May]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: sound/soc//codecs/pcm1789.c:247:19: error: implicit declaration of function 'devm_gpiod_get_optional'
From
Date
On 05/21/2018 05:57 PM, kbuild test robot wrote:
> Hi Mylène,
>
> FYI, the error/warning still remains.

Just needs this patch:
https://marc.info/?l=alsa-devel&m=152644577507060&w=2

Thanks.

> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head: c85061e6e0ee07e131b929e6a17bb2e20d19b321
> commit: 4ae340d1be36378505498606e6c640dd0507ad61 ASoC: codecs: Add support for PCM1789
> date: 9 weeks ago
> config: x86_64-randconfig-s2-05220828 (attached as .config)
> compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026
> reproduce:
> git checkout 4ae340d1be36378505498606e6c640dd0507ad61
> # save the attached .config to linux build tree
> make ARCH=x86_64
>
> All errors (new ones prefixed by >>):
>
> sound/soc//codecs/pcm1789.c: In function 'pcm1789_common_init':
>>> sound/soc//codecs/pcm1789.c:247:19: error: implicit declaration of function 'devm_gpiod_get_optional' [-Werror=implicit-function-declaration]
> pcm1789->reset = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH);
> ^~~~~~~~~~~~~~~~~~~~~~~
>>> sound/soc//codecs/pcm1789.c:247:57: error: 'GPIOD_OUT_HIGH' undeclared (first use in this function)
> pcm1789->reset = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH);
> ^~~~~~~~~~~~~~
> sound/soc//codecs/pcm1789.c:247:57: note: each undeclared identifier is reported only once for each function it appears in
>>> sound/soc//codecs/pcm1789.c:251:2: error: implicit declaration of function 'gpiod_set_value_cansleep' [-Werror=implicit-function-declaration]
> gpiod_set_value_cansleep(pcm1789->reset, 0);
> ^~~~~~~~~~~~~~~~~~~~~~~~
> cc1: some warnings being treated as errors
>
> vim +/devm_gpiod_get_optional +247 sound/soc//codecs/pcm1789.c
>
> 233
> 234 int pcm1789_common_init(struct device *dev, struct regmap *regmap)
> 235 {
> 236 struct pcm1789_private *pcm1789;
> 237
> 238 pcm1789 = devm_kzalloc(dev, sizeof(struct pcm1789_private),
> 239 GFP_KERNEL);
> 240 if (!pcm1789)
> 241 return -ENOMEM;
> 242
> 243 pcm1789->regmap = regmap;
> 244 pcm1789->dev = dev;
> 245 dev_set_drvdata(dev, pcm1789);
> 246
> > 247 pcm1789->reset = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH);
> 248 if (IS_ERR(pcm1789->reset))
> 249 return PTR_ERR(pcm1789->reset);
> 250
> > 251 gpiod_set_value_cansleep(pcm1789->reset, 0);
> 252 msleep(300);
> 253
> 254 INIT_WORK(&pcm1789->work, pcm1789_work_queue);
> 255
> 256 return devm_snd_soc_register_component(dev, &soc_component_dev_pcm1789,
> 257 &pcm1789_dai, 1);
> 258 }
> 259 EXPORT_SYMBOL_GPL(pcm1789_common_init);
> 260
>
> ---
> 0-DAY kernel test infrastructure Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all Intel Corporation
>


--
~Randy

\
 
 \ /
  Last update: 2018-05-22 03:09    [W:0.047 / U:0.860 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site