lkml.org 
[lkml]   [2018]   [May]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 32/33] ASoC: max98095: use match_string() helper
On Mon, May 21, 2018 at 2:58 PM, Yisheng Xie <xieyisheng1@huawei.com> wrote:
> match_string() returns the index of an array for a matching string,
> which can be used intead of open coded variant.


> + int ret = match_string(bq_mode_name, ARRAY_SIZE(bq_mode_name), name);

Rather split and move an assignment to the line before 'if'.

>
> /* Shouldn't happen */

> + if (ret < 0)
> + dev_err(component->dev, "Bad biquad channel name '%s'\n", name);
> + return ret;
> }

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2018-05-22 00:25    [W:0.541 / U:3.508 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site