lkml.org 
[lkml]   [2018]   [May]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/5] staging: lustre: Fix block comments style
On Wed, May 16, 2018 at 08:27:07PM +0200, Sabin Mihai Rapan wrote:
> This patch fixes the checkpatch.pl warning:
>
> WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
>
> Signed-off-by: Sabin Mihai Rapan <sabin.rapan@gmail.com>
> ---
> .../staging/lustre/include/uapi/linux/lustre/lustre_idl.h | 6 ++++--
> .../staging/lustre/include/uapi/linux/lustre/lustre_user.h | 6 ++++--
> 2 files changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/lustre/include/uapi/linux/lustre/lustre_idl.h b/drivers/staging/lustre/include/uapi/linux/lustre/lustre_idl.h
> index e6016a71ad23..f13138972be2 100644
> --- a/drivers/staging/lustre/include/uapi/linux/lustre/lustre_idl.h
> +++ b/drivers/staging/lustre/include/uapi/linux/lustre/lustre_idl.h
> @@ -1526,9 +1526,11 @@ struct mdt_rec_setattr {
> #define MDS_OPEN_HAS_OBJS 020000000000 /* Just set the EA the obj exist */
> #define MDS_OPEN_NORESTORE 0100000000000ULL /* Do not restore file at open */
> #define MDS_OPEN_NEWSTRIPE 0200000000000ULL /* New stripe needed (restripe or
> - * hsm restore) */
> + * hsm restore)
> + */
> #define MDS_OPEN_VOLATILE 0400000000000ULL /* File is volatile = created
> - unlinked */
> + * unlinked
> + */

Always run checkpatch.pl on your patches so you do not get grumpy
maintainers telling you to run checkpatch.pl on your patches :)

Also, do not create a patch to fix up a checkpatch warning, only to have
it add another one, unless you want to have an eternal number of changes
to make over time...

Please fix up and resend the whole series.

thanks,

greg k-h

\
 
 \ /
  Last update: 2018-05-20 14:45    [W:0.078 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site