lkml.org 
[lkml]   [2018]   [May]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] PM / devfreq: Remove redundant frequency adjustment from governors
On 2018년 05월 18일 07:41, Matthias Kaehlcke wrote:
> On Wed, May 16, 2018 at 02:10:51PM -0700, Matthias Kaehlcke wrote:
>> The performance, powersave, simpleondemand and userspace governors
>> determine a target frequency and then adjust it according to the
>> df->min/max_freq limits that might have been set by user space. This
>> adjustment is redundant, it is done in update_devfreq() for any
>> governor, right after governor->get_target_freq().
>>
>> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
>> ---
>> drivers/devfreq/governor_performance.c | 10 ++--------
>> drivers/devfreq/governor_powersave.c | 5 -----
>> drivers/devfreq/governor_simpleondemand.c | 7 +------
>> drivers/devfreq/governor_userspace.c | 16 ++++------------
>> 4 files changed, 7 insertions(+), 31 deletions(-)
>>
>> diff --git a/drivers/devfreq/governor_performance.c b/drivers/devfreq/governor_performance.c
>> index 4d23ecfbd948..31ee30622c00 100644
>> --- a/drivers/devfreq/governor_performance.c
>> +++ b/drivers/devfreq/governor_performance.c
>> @@ -16,14 +16,8 @@
>> static int devfreq_performance_func(struct devfreq *df,
>> unsigned long *freq)
>> {
>> - /*
>> - * target callback should be able to get floor value as
>> - * said in devfreq.h
>> - */
>> - if (!df->max_freq)
>> - *freq = UINT_MAX;
>> - else
>> - *freq = df->max_freq;
>> + *freq = UINT_MAX;
>> +
>> return 0;
>> }
>
> For the record, the frequency adjustment in update_devfreq() is
> currently broken for df->max_freq == 0:
>
> https://patchwork.kernel.org/patch/10407827/

Why don't you send patch set? It is very difficult to track
the history and a correlation between patches. Usually, if patches
have the dependency between patches, send the patch set with cover-letter.

--
Best Regards,
Chanwoo Choi
Samsung Electronics

\
 
 \ /
  Last update: 2018-05-18 01:18    [W:0.088 / U:0.376 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site