lkml.org 
[lkml]   [2018]   [May]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 01/11] perf tests parse-events: Add intel_pt parse test
On Thu, 17 May 2018 22:58:11 +0200
Jiri Olsa <jolsa@redhat.com> wrote:

> On Thu, May 17, 2018 at 05:15:53PM -0300, Arnaldo Carvalho de Melo wrote:
> > So parse_state->error == NULL, Jiri, ideas?
>
> yep, we don't use it in tests.. and when trying intel_pt on
> system without that pmu, the parse_events_add_pmu fails
> and store the error to NULL.. we should check on that err pointer
>
> wrt to the test itself, how about we add callback
> to check if the test is valid before we run it,
> something like below
> jirka

That diff makes this test pass again on x86 without an intel_pt, and
on Arm32/64 (the intel_pt test gets skipped on those machines):

Tested-by: Kim Phillips <kim.phillips@arm.com>

Thanks,

Kim

\
 
 \ /
  Last update: 2018-05-18 00:54    [W:0.083 / U:33.788 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site