lkml.org 
[lkml]   [2018]   [May]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Intel-gfx] [PATCH v2 5/5] media: platform: Add Chrome OS EC CEC driver
Hi Neil,

I love your patch! Yet something to improve:

[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on v4.17-rc5 next-20180517]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/Neil-Armstrong/Add-ChromeOS-EC-CEC-Support/20180516-180519
base: git://linuxtv.org/media_tree.git master
config: m68k-allmodconfig (attached as .config)
compiler: m68k-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=m68k

All errors (new ones prefixed by >>):

drivers/media//platform/cros-ec-cec/cros-ec-cec.c: In function 'cros_ec_cec_get_notifier':
>> drivers/media//platform/cros-ec-cec/cros-ec-cec.c:231:33: error: 'pci_bus_type' undeclared (first use in this function); did you mean 'pci_pcie_type'?
d = bus_find_device_by_name(&pci_bus_type, NULL,
^~~~~~~~~~~~
pci_pcie_type
drivers/media//platform/cros-ec-cec/cros-ec-cec.c:231:33: note: each undeclared identifier is reported only once for each function it appears in

vim +231 drivers/media//platform/cros-ec-cec/cros-ec-cec.c

217
218 static int cros_ec_cec_get_notifier(struct device *dev,
219 struct cec_notifier **notify)
220 {
221 int i;
222
223 for (i = 0 ; i < ARRAY_SIZE(cec_dmi_match_table) ; ++i) {
224 const struct cec_dmi_match *m = &cec_dmi_match_table[i];
225
226 if (dmi_match(DMI_SYS_VENDOR, m->sys_vendor) &&
227 dmi_match(DMI_PRODUCT_NAME, m->product_name)) {
228 struct device *d;
229
230 /* Find the device, bail out if not yet registered */
> 231 d = bus_find_device_by_name(&pci_bus_type, NULL,
232 m->devname);
233 if (!d)
234 return -EPROBE_DEFER;
235
236 *notify = cec_notifier_get_conn(d, m->conn);
237 return 0;
238 }
239 }
240
241 /* Hardware support must be added in the cec_dmi_match_table */
242 dev_warn(dev, "CEC notifier not configured for this hardware\n");
243
244 return -ENODEV;
245 }
246

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[unhandled content-type:application/gzip]
\
 
 \ /
  Last update: 2018-05-17 22:00    [W:0.165 / U:0.208 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site